P3385 #141
Open
P3385 #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zebullon <[email protected]>
Signed-off-by: zebullon <[email protected]>
Signed-off-by: zebullon <[email protected]>
zebullax
force-pushed
the
3385R5
branch
2 times, most recently
from
e2aec7f to
0141d22
Compare
Add test Signed-off-by: zebullon <[email protected]>
Remove backlink Signed-off-by: zebullon <[email protected]>
Signed-off-by: zebullon <[email protected]>
Signed-off-by: acassagnes <[email protected]>
Signed-off-by: zebullax <[email protected]>
Author
|
@katzdm Now that most hacks are gone, could we look into merging this ? |
Signed-off-by: zebullax <[email protected]>
Signed-off-by: zebullax <[email protected]>
Signed-off-by: zebullax <[email protected]> Cleanup Signed-off-by: zebullax <[email protected]> Cleanup Signed-off-by: zebullax <[email protected]>
Signed-off-by: zebullax <[email protected]>
* Stash Stash Stash Signed-off-by: zebullax <[email protected]> * Stash Signed-off-by: zebullax <[email protected]> * Stash Signed-off-by: zebullax <[email protected]> * Revert change to metafunction until we get something working in tablegen Signed-off-by: zebullax <[email protected]> * Emit the code for extractSyntacticArguments Signed-off-by: zebullax <[email protected]> * Check bit for escape hatch Signed-off-by: zebullax <[email protected]> * Fix backend to cast to derived attribute Signed-off-by: zebullax <[email protected]> * Fix constness and get utility out of Attr Signed-off-by: zebullax <[email protected]> * Fix the type of string literal we create for attr Signed-off-by: zebullax <[email protected]> Rename some fluff Signed-off-by: zebullax <[email protected]> * Fix dedup of spelling variants of same attribute Signed-off-by: zebullax <[email protected]> --------- Signed-off-by: zebullax <[email protected]> Augment UT Signed-off-by: zebullax <[email protected]> Factor in namespace when profiling apvalue Signed-off-by: zebullax <[email protected]> Clean up dumb dumb Signed-off-by: zebullax <[email protected]>
Signed-off-by: zebullax <[email protected]>
Signed-off-by: zebullax <[email protected]>
Signed-off-by: zebullax <[email protected]>
Signed-off-by: zebullax <[email protected]>
* Return null reflection for non-reflectable attributes Signed-off-by: zebullax <[email protected]> * Clean up UT Signed-off-by: zebullax <[email protected]> Filter out attributes that are not reflectable in attributes_of Signed-off-by: zebullax <[email protected]> Validate that unsupported attributes are not returned in attributes_of Signed-off-by: zebullax <[email protected]> --------- Signed-off-by: zebullax <[email protected]>
Allow attribute reflection expression in lambda body Signed-off-by: zebullax <[email protected]>
* Add scaffolding to stash from data_member_spec then tag attributes in define_aggregate Signed-off-by: zebullax <[email protected]> * Switch to an Henry based approach without stashing callback to tag attributes Signed-off-by: zebullax <[email protected]> --------- Signed-off-by: zebullax <[email protected]>
* Turn Expr into strings for profiling purposes Signed-off-by: zebullax <[email protected]> * Add a low tiers profiling to ParsedAttr for expression arg Signed-off-by: zebullax <[email protected]> --------- Signed-off-by: zebullax <[email protected]>
Signed-off-by: zebullax <[email protected]>
Add hasAttribute Add unproposed filtering on attribute namespace Add variadic string like enum Signed-off-by: zebullax <[email protected]>
Signed-off-by: zebullax <[email protected]>
Signed-off-by: zebullax <[email protected]>
Rename enum policy Signed-off-by: zebullax <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #
Support for attributes reflection
Describe your changes
Support for attributes reflection
Disclaimer
It goes down happy paths so YMMV, 🟢 stands for
This work in a controlled environment, probably break in a lot of casesStatus
^^[[nodiscard]];std::meta::has_identifier(r)std::meta::is_attribute(r)std::meta::identifier_of(r)std::meta::attributes_of(r)std::meta::appertain(r, v)Note
Attribute argument support is experimental, only supports string argument of
[[nodiscard]]and[[deprecated]]Testing performed
Smoke tests here