forked from llvm/llvm-project
-
Notifications
You must be signed in to change notification settings - Fork 31
Implement std::consteval_hash<std::meta::info>
#170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fullptr
wants to merge
27
commits into
bloomberg:p2996
Choose a base branch
from
fullptr:consteval-hash
base: p2996
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d99a12 to
6850e1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p3816r0.html in a way that is stable across repeated runs of the compiler on unchanged source code.
The simplest way to define the hash is to just hash the AST pointer that the given reflection represents, but this results in different hash values with each compilation run which is undesirable (the compiler should not introduce sources of instability, repeated compilations should yield the same result).
This implementation instead looks at what the reflection represents underneath and constructs a hash based on the value, resulting in hash values that are stable across repeated runs. Creating hashes for types in this way proved trickier, so this PR instead assigns a unique value to every type which gets for its hash value instead. These are defined in the order that the types are, so rearranging types in the source code can change the values, but they remain stable across repeat builds.
The obvious downside with this approach is that it needs to be updated whenever future standards introduce new constructs that can be reflected. A second approach can be found here which uses a way to generate a stable value from the underlying pointer AST which makes the implementation much simpler and does not need to be continuously updated with future standards.