Skip to content

feat: add InvokeSimpleWithRawParam for multi params with same key name #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alswl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add InvokeSimpleWithRawParam for multi params with same key name #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,8 @@ func (j *Job) HasQueuedBuild() {
panic("Not Implemented yet")
}

func (j *Job) InvokeSimple(ctx context.Context, params map[string]string) (int64, error) {
// InvokeSimpleWithRawParam starts a build with parameters in url.Values, it allowed duplicate key.
func (j *Job) InvokeSimpleWithRawParam(ctx context.Context, params url.Values) (int64, error) {
isQueued, err := j.IsQueued(ctx)
if err != nil {
return 0, err
Expand All @@ -437,11 +438,7 @@ func (j *Job) InvokeSimple(ctx context.Context, params map[string]string) (int64
if len(parameters) > 0 {
endpoint = "/buildWithParameters"
}
data := url.Values{}
for k, v := range params {
data.Set(k, v)
}
resp, err := j.Jenkins.Requester.Post(ctx, j.Base+endpoint, bytes.NewBufferString(data.Encode()), nil, nil)
resp, err := j.Jenkins.Requester.Post(ctx, j.Base+endpoint, bytes.NewBufferString(params.Encode()), nil, nil)
if err != nil {
return 0, err
}
Expand All @@ -468,6 +465,15 @@ func (j *Job) InvokeSimple(ctx context.Context, params map[string]string) (int64
return number, nil
}

// InvokeSimple starts a build with parameters in map.
func (j *Job) InvokeSimple(ctx context.Context, params map[string]string) (int64, error) {
data := url.Values{}
for k, v := range params {
data.Set(k, v)
}
return j.InvokeSimpleWithRawParam(ctx, data)
}

func (j *Job) Invoke(ctx context.Context, files []string, skipIfRunning bool, params map[string]string, cause string, securityToken string) (bool, error) {
isQueued, err := j.IsQueued(ctx)
if err != nil {
Expand Down