more lenient osgi.ee=JavaSE for unknown JDKs #6859
Open
+131
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisrueger
changed the title
chrisrueger
force-pushed
the
6858-improve-osgiee-for-unknown-jdk
branch
2 times, most recently
from
3f533d5 to
c63fede
Compare
chrisrueger
force-pushed
the
6858-improve-osgiee-for-unknown-jdk
branch
from
c63fede to
8d418ec
Compare
|
In the advent of regular Java versions released this seems the right approach. In general the EE enum might needs to be revised by:
|
|
@chrisrueger I have fired up a task for the AI here maybe it produces something useful as a base-ground: |
Just adding that currently there are two enums holding Java versions:
|
For a yet to bnd unknown JDK (e.g. JDK-10000) Instead of ``` Require-Capability: osgi.ee;filter:="(osgi.ee=UNKNOWN)" ``` we now create Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=9955))" for a .class file with u2 major_version 10000 (9955 == 10000 - 45) Signed-off-by: Christoph Rueger <[email protected]>
chrisrueger
force-pushed
the
6858-improve-osgiee-for-unknown-jdk
branch
from
8d418ec to
93558d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6858
Experimental:
For a yet to bnd unknown JDK (e.g. JDK-10000) Instead of
we now create
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=9955))"
for a .class file with u2 major_version 10000 (9955 == 10000 - 45)