Finish LDAP implementation

[marek-obuchowicz]

Seems that LDAP implementation was not really "not tested", but "not finished". As it was needed pretty much in one of our projects - here comes the implementation. Have been tested with OpenLDAP server and works pretty fine, also in production.

[bnoguchi]

@marek-obuchowicz Thanks!

[aaroncalderon]

@marek-obuchowicz Thanks also, however, you make the assumption that result.uid will match the login on ldap.js#L39. that is not the case in all Active Directory deployments (like in my case). So I'm trying to figure out how to address this.

Any ideas?

Update

So, since you have provided the template for how to implement the LDAP, i had to override your methods to be able to keep the backwards compatibility (to be able to upgrade everyauth) and still be able to authenticate with my organization's implementation of AD.

Thanks

P.S.

Did you had the chance to implement the .findOrCreateUser() method?

[marek-obuchowicz]

great, htnaks for the input... if this is common case for AD (i don't have access at the moment to any), let me know how you have handled that

[aaroncalderon]

@marek-obuchowicz I submitted an issue #482 and pull request #483 about this. Along with some documentation on the README.md, even though it was mostly copy and paste from the original.

Unless you think is a better idea to merge my ldapfork and ldap.

Any feedback is appreciated.