Include the puma environment as a dimension #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added an extra dimension for the name of the environment puma is currently configured for. Made this overridable with an environment variable. * Fixed fetcher spec to use the expected unix socket. * Updated and fixed sender spec metric data.
|
I think this issue has been resolved by #16. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is only a singular customizable dimension added to the metrics. The readme suggests changing the value to your app name like
App:demo-web-pumabut if you have a staging and production environment in the same region you can't tell the metrics apart.This PR adds a environment dimension set to puma's environment or whatever
PUMA_CLOUDWATCH_ENVIRONMENTis set to if you want to override it. I also fixed the fetcher and sender specs so they pass on a fresh setup.