-
Notifications
You must be signed in to change notification settings - Fork 40
Mostly GitHub workflow and build system changes #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Removed usage of Boost.Filesystem APIs that were deprecated and then removed.
Update Boost.Filesystem usage
…a source in install targets.
Add support for modular build structure.
Document that metis_reader expects a seekable stream
Remove mentions of bsp_process_group from docs
Should have done this when I took over Boost.Graph, whoops.
|
@jzmaddock , are you available to review? |
|
The changes look fine to me. Any idea what's started causing all the segfaults in the tests? |
|
BTW we could really use an MSVC CI runner too. |
No idea! I'll have to investigate. |
|
Very curious that the macos (clang) build passes. |
|
@aminiussi maybe you can help here: do you know why these |
|
I test boost.mpi with HPE/Cray MPI which is mpich based so nothing trivial comes to mind. I only test with cmake and I think there are no cmake based tests for graph parallel, so I'll have to make a b2/gcc13/mpich build on my ubuntu laptop to sees if I can reproduce the issue. |
|
I would replace: with Then, I suspect the test will fail the Since the mpi_process_group class allocate one incomming and outgoing communication structures in containers of size comm.size(), sending a message to proc 1 will retrieve a non existing outgoing structure (in mpi_process_group.ipp:173). I suspect the problem is in the project_config.jam generated file that does not actually select the mpich implementation, which ends up launching 2 singleton instead of two process MPI jobs. |
And some fixes to the documentation, and one fix to the code.
Also updated the maintainer to myself, which I should have done a few years ago when I took over Boost.Graph, whoops.