Skip to content

Move 'arg' variable to detail namespace (issue #150) #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vprus merged 4 commits into from
Dec 4, 2025
Merged

Move 'arg' variable to detail namespace (issue #150) #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
714e07d
Initial plan
Copilot Dec 4, 2025
1cc6874
Move 'arg' variable to detail namespace (issue #150)
Copilot Dec 4, 2025
976f3d7
Complete PR for moving arg variable to detail namespace
Copilot Dec 4, 2025
255c207
Delete _codeql_detected_source_root
vprus Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/boost/program_options/detail/value_semantic.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ namespace boost { template<class T> class optional; }

namespace boost { namespace program_options {

extern BOOST_PROGRAM_OPTIONS_DECL std::string arg;
namespace detail {
extern BOOST_PROGRAM_OPTIONS_DECL std::string arg;
}

template<class T, class charT>
std::string
typed_value<T, charT>::name() const
{
std::string const& var = (m_value_name.empty() ? arg : m_value_name);
std::string const& var = (m_value_name.empty() ? detail::arg : m_value_name);
if (!m_implicit_value.empty() && !m_implicit_value_as_text.empty()) {
std::string msg = "[=" + var + "(=" + m_implicit_value_as_text + ")]";
if (!m_default_value.empty() && !m_default_value_as_text.empty())
Expand Down
6 changes: 4 additions & 2 deletions src/value_semantic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,14 @@ namespace boost { namespace program_options {
}
#endif

BOOST_PROGRAM_OPTIONS_DECL std::string arg("arg");
namespace detail {
BOOST_PROGRAM_OPTIONS_DECL std::string arg("arg");
}

std::string
untyped_value::name() const
{
return arg;
return detail::arg;
}

unsigned
Expand Down
Loading