Release import adjustments #2045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st downloads table layout to fit
…en provided; Made fully_completed marking more specific; Added logging improvements
Collaborator
|
@daveoconnor luckily the import issues were replicable, on staging yesterday I deleted 1.90.0 and re-imported with a similar incomplete result. After this PR, let's try that again. Maybe next week. Delete 1.90.0 on staging and run the import. |
Collaborator
|
Deleted 1.90.0 in my local, ran the import, 1.90.0 is back showing fully imported. @gregjkal could you merge this one for me please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the last release the import process wasn't completing, due to imprecise filtering and timing on marking fully completed. This wasn't noticeable before release because there needed to be an existing beta that was older and had the same version number.
Investigating that I cleaned up a few other issues that would have been problems and improved the logging.
Testing: locally, delete the 1.90.0 version data, confirm the 1.90.0 beta exists. Then run "import new versions" in the admin interface. When the process has completed, confirm that 1.90.0 exists and has been marked as fully completed.