Skip to content

Conversation

@gargolito
Copy link
Contributor

keyring/kwallet.py: Modified VortaKWallet5Keyring to use enums for results and added error handling. More logging. Reorganized methods, added more doc strings, added pytests

Description

keyring/kwallet.py: Modified VortaKWallet5Keyring to use enums for results and added error handling. More logging. Reorganized methods, added more doc strings, added pytests

Related Issue

Issue #2198

Motivation and Context

See Issue 2198 Added option to prompt user for wallet name if none can be found or determined.

How Has This Been Tested?

Pytest unit tests and mocks, used QT 6.9 libraries in Kubuntu Linux. (Noble 24.04), and "works-on-my-machine" test :)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@m3nu m3nu merged commit 68e0452 into borgbase:master Nov 28, 2025
5 of 7 checks passed
@m3nu
Copy link
Contributor

m3nu commented Nov 28, 2025

Thanks for the great addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants