Skip to content

[BUG-fix] Cannot Start-VMX with error Vmware version not match #23 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
azhahes wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[BUG-fix] Cannot Start-VMX with error Vmware version not match #23 #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
737972e
[BUG-fix] Cannot Start-VMX with error Vmware version not match #23
Oct 26, 2021
f0d7671
Fix isssue in matching version
Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions vmxtoolkit/vmxtoolkit.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3342,7 +3342,7 @@ function Start-VMX
if (($vmx) -and ($vmx.state -ne "running"))
{
[int]$vmxhwversion = (Get-VMXHWVersion -config $vmx.config).hwversion
if ($vmxHWversion -le $vmwareversion.major)
if (Is-MatchingHWVersion -VMwareMajorVersion $($vmwareversion.Major) -VMXHWversion $vmxHWversion)
{
Write-Verbose "Checking State for $vmxname : $($vmx.vmxname) : $($vmx.state)"
Write-Verbose "creating Backup of $($vmx.config)"
Expand Down Expand Up @@ -3400,9 +3400,9 @@ function Start-VMX
Write-Warning "There was an error starting the VM: $cmdresult"
}
}
else { Write-Error "Vmware version does not match, need version $vmxhwversion " }
else { Write-Error "Vmware version does not match, update vmx hardware version as per https://kb.vmware.com/s/article/1003746 " }
}
elseif ($vmx.state -eq "running") { Write-Verbose "VM $VMXname already running" } # end elseif
elseif ($vmx.state -eq "running") { Write-Host "VM $VMXname already running" } # end elseif

else { Write-Verbose "VM $VMXname not found" } # end if-vmx
}
Expand Down Expand Up @@ -6442,3 +6442,30 @@ Write-Host -ForegroundColor Green "[success]"
$Object | Add-Member -MemberType NoteProperty -Name LoggedIn -Value $true
Write-Output $Object
}

function Is-MatchingHWVersion{
[CmdletBinding(HelpUri = "https://github.com/bottkars/vmxtoolkit/wiki")]
param (
[Parameter(Mandatory = $true, ValueFromPipeline = $true)][int]$VMwareMajorVersion,
[Parameter(Mandatory = $true, ValueFromPipeline = $true)][int]$VMXHWversion
)
begin{
}
process{

Write-Verbose "VM ware major version: $VMwareMajorVersion"
Write-Verbose "VMX HW version: $VMXHWversion"

switch ($VMwareMajorVersion)
{
16 { if(($VMXHWversion -eq 18) -or ($VMXHWversion -eq 19)){ return $true } }
15 { if(($VMXHWversion -eq 16) -or ($VMXHWversion -eq 16)){ return $true } }
Default {
if($VMXHWversion -eq $VMwareMajorVersion){ return $true }
}
}
return $false
}
end { }

}