Build on Windows

[bradlarsen]

No description provided.

[arilou]

Just wanted to point out it seems like VectorScan master branch might have some fixes that can help.
VectorCamp/vectorscan@cfa8397
And also they seem to release 5.4.12 which contains this commit as far as i understand

[bradlarsen]

@arilou thanks for the pointer!

I actually got Vectorscan building on windows in CI above; it was building the vectorscan test suite that was the hangup. It looked like a source patch might be needed for the tests to either make some method definitions defined in a header file inline or move them into a source file, to avoid "multiple definition" linker errors on the toolchain being used on Windows. Nothing insurmountable; just a question of priorities.

[arilou]

Ah that's really nice to know, another thing in the patch I referenced to, hopefully it will allow building with FAT runtime for Windows.

Also we did not want to break anything but maybe you want to take a lot of some of the changes we have made, perhaps part of them you will want to merge here

https://github.com/idowiz/vectorscan-rs/commits/wiz/

[bradlarsen]

Also we did not want to break anything but maybe you want to take a lot of some of the changes we have made, perhaps part of them you will want to merge here

https://github.com/idowiz/vectorscan-rs/commits/wiz/

There are a number of patches that look useful there! I may cherry-pick some of those.