Skip to content

fix: neon now compiles #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: fix: dpp::cluster::register_command with coroutine handler on windows
merged 1 commit into from
Oct 30, 2024
Merged

fix: neon now compiles #1313

merged 1 commit into from
Oct 30, 2024

Conversation

@Jaskowicz1
Copy link
Contributor

This PR fixes NEON not compiling.

Closes #1309

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@Jaskowicz1 Jaskowicz1 self-assigned this Oct 30, 2024
@Jaskowicz1 Jaskowicz1 added the bug Something isn't working label Oct 30, 2024
@github-actions github-actions bot closed this Oct 30, 2024
@braindigitalis braindigitalis changed the base branch from master to dev October 30, 2024 21:33
@brainboxdotcc brainboxdotcc deleted a comment from github-actions bot Oct 30, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Oct 30, 2024
@Jaskowicz1 Jaskowicz1 merged commit 9715996 into dev Oct 30, 2024
128 of 130 checks passed
@Jaskowicz1 Jaskowicz1 deleted the neon_fix branch November 1, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braindigitalis braindigitalis braindigitalis approved these changes

Assignees

@Jaskowicz1 Jaskowicz1

Labels

bug Something isn't working code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

NEON does not compile

2 participants

@Jaskowicz1 @braindigitalis