Skip to content

Conversation

@peti446
Copy link

@peti446 peti446 commented Jan 14, 2025

std::condition_variable is used in the awaitable.h file, so it should be included in it.
If you only include dpp::taks or similar header files, it will cause a linker error as it will not be able to link against std::condition_variabl, normally you would include dpp.h or other files that include a lot so It's not really noticeable.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added documentation Improvements or additions to documentation code Improvements or additions to code. labels Jan 14, 2025
@github-actions
Copy link
Contributor

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions bot closed this Jan 14, 2025
@braindigitalis
Copy link
Contributor

thanks for the PR, it would need to go into dev branch (not master) if it is for the upcoming 10.1 release, or in the 10.0 branch if it is for the 10.0.x releases (this is most likely).

@braindigitalis braindigitalis changed the base branch from master to 10.0 January 15, 2025 11:37
@braindigitalis
Copy link
Contributor

i have reopened this PR and targeted it at 10.0. The 10.1 dev branch already has this fix. Once the CI passes, I shall merge it. Thanks for your contribution!

@braindigitalis braindigitalis merged commit 9df5b87 into brainboxdotcc:10.0 Jan 15, 2025
46 checks passed
@peti446
Copy link
Author

peti446 commented Jan 15, 2025

Thanks for taking care of the retarget seems like I forgot to do it last night ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code. documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants