Skip to content

Conversation

@supsm
Copy link
Contributor

@supsm supsm commented Jan 20, 2025

If DPP_CORO is configured to be true, the make_struct.php will always be run, even if not on UNIX or if PHP isn't found. This PR moves the relevant execute_process to where the other php files are run.

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions bot closed this Jan 20, 2025
@github-actions github-actions bot added the build Issue or Pull Request related to the build process label Jan 20, 2025
@supsm
Copy link
Contributor Author

supsm commented Jan 20, 2025

oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issue or Pull Request related to the build process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants