Skip to content

Conversation

@ProjectSky
Copy link
Contributor

fix cluster::channel_invites_get incorrect endpoint.

The third parameter (minor) is an empty str "", resulting in the incorrect API endpoint:

  • Actual: GET /api/v10/channels/{channel_id}
  • Expected: GET /api/v10/channels/{channel_id}/invites
void cluster::channel_invites_get(const class channel &c, command_completion_event_t callback) {
	rest_request_list<invite>(this, API_PATH "/channels", std::to_string(c.id), "", m_get, "", callback);
	//                                                                            ^^^ Missing "invites"
}

Code change checklist

  • I have ensured that all methods and functions are fully documented using doxygen style comments.
  • My code follows the coding style guide.
  • I tested that my change works before raising the PR.
  • I have ensured that I did not break any existing API calls.
  • I have not built my pull request using AI, a static analysis tool or similar without any human oversight.

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Thank you for your contribution, but PRs must be raised against the dev branch. Please log your pull request against the dev branch not master. You can also retarget this pull request, then reopen it.

@github-actions github-actions bot closed this Oct 3, 2025
@github-actions github-actions bot added the code Improvements or additions to code. label Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Improvements or additions to code.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants