-
-
Couldn't load subscription status.
- Fork 187
feat: Current Member Edit now supports banner, avatar and bio #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This needs #1503 merged and then coro needs to be auto generated. |
|
This needs testing in a bot before we go ahead with marking as Ready for Review |
|
PR has now been marked as ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have minor changes to request and I can't do it on mobile, blocking this until tomorrow 😈
src/dpp/cluster/guild.cpp
Outdated
| const std::string post_data = j.dump(-1, ' ', false, json::error_handler_t::replace); | ||
| rest_request<confirmation>(this, API_PATH "/guilds", std::to_string(guild_id), "members/@me", m_patch, std::move(post_data), std::move(callback)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const std::string post_data = j.dump(-1, ' ', false, json::error_handler_t::replace); | |
| rest_request<confirmation>(this, API_PATH "/guilds", std::to_string(guild_id), "members/@me", m_patch, std::move(post_data), std::move(callback)); | |
| std::string post_data = j.dump(-1, ' ', false, json::error_handler_t::replace); | |
| rest_request<confirmation>(this, API_PATH "/guilds", std::to_string(guild_id), "members/@me", m_patch, std::move(post_data), std::move(callback)); |
You have to remove the const too, moving a const object just copies



This PR allows bots to edit their banner, avatar and bio, per guild.
Code change checklist