Skip to content

Conversation

@nickedwards
Copy link

Doing some work where I need to change the images on a video to remote images uploaded in our own CMS.

There might be a few more endpoints I add in later, but for now here's the work I've done for adding remote images.

$this->fieldChanged('remote_url');
return $this;
}
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline.

$this->fieldChanged('remote_url');
return $this;
}
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline.

public function postJSON() {
$data = [];
foreach ($this as $field => $val) {
if ($field === 'changedFields' || $field === 'fieldAliases' || $val === NULL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this check removed?

$data = [];
foreach ($this->changedFields as $field) {
$val = $this->{$field};
if ($val === NULL) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this check removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants