Updates from Bitness

[leogdion]

No description provided.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bitness-v0.0.8

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v2.0.0-alpha.2@532371b). Learn more about missing BASE report.

Additional details and impacted files

@@                Coverage Diff                @@
##             v2.0.0-alpha.2      #74   +/-   ##
=================================================
  Coverage                  ?   65.39%           
=================================================
  Files                     ?       31           
  Lines                     ?      526           
  Branches                  ?        0           
=================================================
  Hits                      ?      344           
  Misses                    ?      182           
  Partials                  ?        0           

Flag	Coverage Δ
spm	66.79% <ø> (?)
swift-6.1-jammy	65.59% <ø> (?)
swift-6.1-jammy-nightly	65.59% <ø> (?)
swift-6.1-noble	65.59% <ø> (?)
swift-6.1-noble-nightly	65.59% <ø> (?)
swift-6.2-jammy	65.59% <ø> (?)
swift-6.2-jammy-nightly	65.59% <ø> (?)
swift-6.2-noble	65.59% <ø> (?)
swift-6.2-noble-nightly	65.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[claude]

Pull Request Review: Updates from Bitness

Summary

This PR makes 2,155 deletions and 242 additions across 115 files, primarily consisting of:

1. Copyright header simplification - Replacing verbose MIT license headers with concise one-liners
2. Numeric literal formatting - Adding underscores to improve readability

---

✅ Positive Aspects

1. Copyright Header Simplification

• Consistent transformation from verbose MIT license (~26 lines) to concise format (3 lines)
• Pattern: // FileName.swift + // Copyright (c) 2025 BrightDigit.
• Reduces file size and improves readability
• Consistent across all source files (Sources/) and test files (Tests/)

2. Numeric Literal Improvements

• Proper use of underscores for readability: 1000 → 1_000, 5000 → 5_000, 1024 → 1_024
• Examples include millisecond conversions, byte sizes, and sensor pressure ranges
• Follows Swift best practices for numeric literals

3. Code Quality

• Whitespace cleanup (e.g., ColorPreview.swift:108 - removed trailing whitespace)
• No functional code changes beyond formatting
• Changes are purely cosmetic and don't affect behavior

---

⚠️ Concerns & Recommendations

1. Copyright Year Consistency

• All headers now show Copyright (c) 2025 BrightDigit.
• Question: Should files created in earlier years retain their original copyright year, or is using 2025 universally intentional?
• Recommendation: Verify this aligns with your copyright policy. Some projects use creation year, others use last-modified year.

2. License Information Removal

• The verbose MIT license text has been completely removed from all files
• Concern: While this reduces verbosity, ensure there's a top-level LICENSE file in the repository
• Recommendation: Verify LICENSE or LICENSE.md exists at the repository root with the full MIT license text

3. PR Description

• The PR body is empty
• Recommendation: Add a description explaining:
  • Why the copyright headers were changed (e.g., "Adopting SPDX-style copyright headers per project standards")
  • Confirmation that numeric literal changes were automated (e.g., via SwiftFormat/SwiftLint)
  • Any context about "Bitness" mentioned in the PR title

4. Testing & Validation

• Changes appear mechanical and low-risk
• Recommendation: Ensure CI/CD passes:
  • make build succeeds
  • make test passes with existing coverage
  • make lint passes (especially if linter rules changed)

5. Git History

• Large reformatting PRs can make git blame less useful
• Recommendation: Consider adding this commit hash to .git-blame-ignore-revs (if your project uses this feature)

---

🔍 Specific File Reviews

MockSession.swift (Tests/SundialKitConnectivityTests/MockSession.swift)

• Added 5 lines, deleted 0 (beyond copyright header change)
• Changes appear to be copyright header update only
• No logic changes detected

Numeric Literal Examples Reviewed:

• ✅ Date+Milliseconds.swift: 1000 → 1_000 (correct)
• ✅ MessageHistoryRow.swift: 1024 → 1_024 (bytes - correct)
• ✅ LatencyTestRequestExtensions.swift: 5000 → 5_000 (correct)

---

📋 Security & Performance

Security:

• ✅ No security concerns
• Changes are purely formatting/documentation
• No code logic altered

Performance:

• ✅ No performance impact
• Numeric literal formatting has zero runtime cost
• Shorter headers reduce file I/O marginally (negligible)

---

🧪 Test Coverage

• Test files updated consistently with source files
• Copyright headers in test files also simplified
• No test logic changes detected
• Recommendation: Run full test suite to confirm no regressions

---

📝 Final Recommendations

1. Add PR Description: Explain the rationale for these changes
2. Verify LICENSE file: Ensure repository root has full MIT license text
3. Confirm CI Passes: Especially linting if rules were updated
4. Consider .git-blame-ignore-revs: For easier future blame analysis
5. Review Copyright Year Policy: Decide if 2025 is correct for all files

---

✅ Approval Recommendation

Conditional Approval - The changes are clean and consistent, but please address:

1. Confirm copyright year policy (2025 for all files)
2. Add PR description
3. Ensure CI/CD passes

Once these items are confirmed, this PR is safe to merge.

---

Code Quality: ⭐⭐⭐⭐⭐ (5/5) - Consistent, clean formatting
Risk Level: 🟢 Low - No functional changes
Test Impact: 🟢 None - No test logic changes

Great work on standardizing the codebase formatting! 🎉