fix: Fix touch events with rotation OS-20284 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caneraltinbasak
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Mouse events were working correctly with htmlwidget rotation, but touch events weren't. The reason for this is that WindowTargeter::FindTargetInRootWindow was comparing non-transformed/rotated touch co-ordinates against transformed/rotated window bounds.
I looked at adding test coverage to verify this fix, but webContents.sendInputEvent doesn't support touch events. Even if the Electron and Chromium code was modified to support this, it injects the events into RenderWidgetHostImpl, which is after the window targeter code. To test this touch events would have to be injected at the wayland level.
Checklist
npm testpassesRelease Notes
Notes: