-
Notifications
You must be signed in to change notification settings - Fork 1.3k
add gemini 3 preview #1445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add gemini 3 preview #1445
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 13 files
Architecture diagram
sequenceDiagram
participant Client
participant SDK as "Stagehand / Server"
participant Mapper as "Model Provider Map"
participant Google as "Google API"
Note over Client,Google: NEW: Support for Gemini 3 Preview Models
Client->>SDK: Initialize { model: "gemini-3-flash-preview" }
SDK->>Mapper: Map model string to provider
alt NEW: Model Resolution
Mapper->>Mapper: Lookup "gemini-3-flash-preview"
Note right of Mapper: CHANGED: Resolves to "google"\n(previously undefined)
end
Mapper-->>SDK: Provider: "google"
SDK->>SDK: Load Credentials (GOOGLE_GENERATIVE_AI_API_KEY)
Client->>SDK: Execute LLM Task (eval or agent)
SDK->>Google: API Request (model="gemini-3-flash-preview")
Note right of Google: External call to\nnew preview model
Google-->>SDK: Response
SDK-->>Client: Result
Greptile SummaryAdded support for two new Gemini 3 preview models ( Key Changes:
Critical Issue:
Confidence Score: 3/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Stagehand as Stagehand SDK
participant LLMProvider
participant ModelMap as modelToProviderMap
participant GoogleClient
participant GoogleAPI as Google Gemini API
User->>Stagehand: Initialize with model: "gemini-3-flash-preview"
Stagehand->>LLMProvider: getClient("gemini-3-flash-preview")
LLMProvider->>ModelMap: Lookup provider for model
ModelMap-->>LLMProvider: Returns "google"
LLMProvider->>GoogleClient: Create GoogleClient instance
GoogleClient-->>LLMProvider: Return client
LLMProvider-->>Stagehand: Return GoogleClient
Stagehand->>GoogleClient: Make LLM request
GoogleClient->>GoogleAPI: API call with gemini-3-flash-preview
GoogleAPI-->>GoogleClient: Model response
GoogleClient-->>Stagehand: Return response
Stagehand-->>User: Return result
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
pnpm-lock.yamllogic:
pnpm-lock.yamldeleted - this will cause dependency resolution issues and should be regenerated withpnpm install
12 files reviewed, 1 comment
|
hey @ell-hol have you tried passing the model as |
|
@miguelg719 it should work but I haven't been able to test locally (not enough memory to build) |
pirate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approve but try and undo all those parens removals before merging
pirate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see earlier comments, remove the lockfile changes and formatting changes
|
FYI gemini 3 flash has specific inference configs that seem to improve performance, we might make these the default for it after some testing |
This reverts commit aaba4f7.
why
model was unavailable in the sdk
what changed
model is now available to use in the sdk
test plan
the existing tests should pass, no mod needed
Summary by cubic
Adds support for Gemini 3 preview models so they can be selected and used across the SDK and server. Maps both models to the Google provider with no breaking changes.
Written for commit de14472. Summary will update automatically on new commits.