Fix opts.poll = false#346
Open
ChrisHarrow wants to merge 2 commits intobrowserify:masterfrom
ChrisHarrow:fix_poll_false
Open
Fix opts.poll = false#346ChrisHarrow wants to merge 2 commits intobrowserify:masterfrom ChrisHarrow:fix_poll_false
ChrisHarrow wants to merge 2 commits intobrowserify:masterfrom
ChrisHarrow:fix_poll_false
Conversation
Watchify currently ignores options pull = false. With this fix Watchify is forwarding this option as usePolling = false to chokidar. Without this option chokidar is using too much CPU resources as it is using polling by default on my mac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watchify currently ignores options pull = false.
With this fix Watchify is forwarding this option as usePolling = false to chokidar.
Without this option chokidar is using too much CPU resources as it is using polling by default on my mac.