Test data not being uploaded for xdist enabled but numprocesses set to 0 #81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SkyPilot, we disabled xdist parallelism on the Buildkite CI environment but allow it locally and in other environments to reduce memory usage on Buildkite.(See #7794)
So we need xdist enabled but override the
numprocessesoption on the fly.This results in the xdist environment being set, and
numprocessesalso being set but potentially set to 0 in special cases.In this case, the plugin doesn't upload any data, So we collect no data in our buildkite env.
This PR fixes the issue by treating this case as if xdist is not enabled, allowing the main thread to upload the data.