Skip to content

Conversation

@amanpalariya
Copy link

I'm confused

Satvinder31415 and others added 2 commits December 16, 2019 09:39
Removed redundant double call to diagonal_win() in winning_move()

update logo

update logo

update logo

update logo

Resolved undo issue#13

Generalised some expressions

Generalised some expressions

Works for different board sizes

Added animation and changable board patterns

Update README.md

Create CODE_OF_CONDUCT.md

resolved col bug

Resolved issue#21

run black on the project

Minor bug fixes

Added animation and changable board pattern

Board pattern

Changed a comment
@bymayanksingh
Copy link
Owner

@amanpalariya don't be confused, you have done exactly what I asked you to do.

@bymayanksingh
Copy link
Owner

bymayanksingh commented Dec 17, 2019

we have some conflicts here.. please remove them.. also I am very happy with your coin drop animation.. can you keep only keep these changes

  • coin drop animation
  • generalizations
  • ability to change aesthetics

I am a bit reluctant to merge other changes such as:

  1. reduced font size.
  2. increased section height.

What I will suggest is don't do anything with this section, keep it as it is !

Screenshot from 2019-12-17 07-52-28

The message on the top of the screen will always appear in the center for all board sizes
@amanpalariya
Copy link
Author

Done 👍🏻

@amanpalariya
Copy link
Author

If this PR is merged, people working on issue #7 will have to change the code a little because the board is drawn with coloured rectangle + black circle in their branch and I have done it using transparent tileable pattern board1_100px.png. Coin drop animation will not work without a transparent board.

@bymayanksingh
Copy link
Owner

thanks for the amazing job done @amanpalariya
I will see what I can do while merging in your PR as we have 2 other open PRs for issue 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants