This repository was archived by the owner on Apr 6, 2021. It is now read-only.
Open
Conversation
Contributor
|
+1 |
nightwing
reviewed
Feb 1, 2017
| @@ -410,6 +410,7 @@ function Architect(config) { | |||
| var services = app.services = { | |||
| hub: { | |||
Contributor
There was a problem hiding this comment.
If we are allowing plugins to access app, using imports, would it be better to do hub: app instead?
Contributor
Author
There was a problem hiding this comment.
some plugins may already be called "app" and would confuse, and as for "hub" is already identified as a core architect plugin that "looks" to be barely used and could be used for "architect app" events for plugins, example plugin would be a testing plugin, using hub events to check plugins for test, and then could be removed without modifying plugin config files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it felt convenient to have the "hub" service 'on' function argument 'callback' to inherit architect