feat: [shard-distributor] rely on dynamic config for migration mode #7391
+92
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleonoradgr
requested review from
3vilhamster,
Groxx,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
sankari165
reviewed
Oct 29, 2025
Comment on lines
+74
to
+75
| - value: "onboarded" | ||
| - value: "local_pass" |
Contributor
Author
There was a problem hiding this comment.
it is the default value, if you don't express contrains, anf then values with constrains for certain namespaces
sankari165
reviewed
Oct 29, 2025
| // KeyName: shardDistributor.migrationMode | ||
| // Value type: String | ||
| // Default value: local_pass | ||
| // Default value: onboarded |
Member
There was a problem hiding this comment.
maybe a comment on diifferent values could be helpful
Contributor
Author
There was a problem hiding this comment.
it is already there, need to expand up :)
Member
|
nit: there is a typo in the PR title |
eleonoradgr
changed the title
sankari165
approved these changes
Oct 30, 2025
eleonoradgr
force-pushed
the
edigregorio/dynamic-config
branch
from
faff0ba to
f063a1e
Compare
Signed-off-by: edigregorio <[email protected]>
Signed-off-by: edigregorio <[email protected]>
This reverts commit f063a1e. Signed-off-by: edigregorio <[email protected]>
eleonoradgr
force-pushed
the
edigregorio/dynamic-config
branch
from
6bae84e to
6d938ed
Compare
Theis-Mathiassen
pushed a commit
to AndreasHolt/cadence
that referenced
this pull request
Nov 11, 2025
…adence-workflow#7391) <!-- Describe what has changed in this PR --> **What changed?** Move the logic for the migration mode to use dynamic config instead of static config. Next step is to clean up the static config once the behavior is tested with multiple configuration changes. <!-- Tell your future self why have you made these changes --> **Why?** migration should be done incrementally and this is easier to control with config rollout and not code rollout. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** unit tests and local development. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** shard-distributor-canary service cannot operate correctly if shard-distributor do not use the right configuration <!-- Is it notable for release? e.g. schema updates, configuration or data migration required? If so, please mention it, and also update CHANGELOG.md --> **Release notes** <!-- Is there any documentation updates should be made for config, https://cadenceworkflow.io/docs/operation-guide/setup/ ? If so, please open an PR in https://github.com/cadence-workflow/cadence-docs --> **Documentation Changes** --------- Signed-off-by: edigregorio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Move the logic for the migration mode to use dynamic config instead of static config. Next step is to clean up the static config once the behavior is tested with multiple configuration changes.
Why?
migration should be done incrementally and this is easier to control with config rollout and not code rollout.
How did you test it?
unit tests and local development.
Potential risks
shard-distributor-canary service cannot operate correctly if shard-distributor do not use the right configuration
Release notes
Documentation Changes