feat: Merge app entitlements & provisioning profiles entitlements for iOS builds #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajanuar is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
ajanuar
changed the title
ajanuar
changed the title
Author
|
Hi @thymikee , this PR is ready to review. I'm doing testing internally with my project, i'll update it here with the result. |
thymikee
reviewed
Dec 4, 2025
Comment on lines
+164
to
+180
| const transferRules = [ | ||
| 'com.apple.developer.icloud-container-identifiers', | ||
| 'com.apple.developer.icloud-services', | ||
| 'com.apple.developer.ubiquity-kvstore-identifier', | ||
| 'com.apple.developer.icloud-container-environment', | ||
| 'com.apple.security.application-groups', | ||
| 'keychain-access-groups', | ||
| 'com.apple.developer.associated-domains', | ||
| 'com.apple.developer.healthkit', | ||
| 'com.apple.developer.homekit', | ||
| 'inter-app-audio', | ||
| 'com.apple.developer.networking.networkextension', | ||
| 'com.apple.developer.maps', | ||
| 'com.apple.external-accessory.wireless-configuration', | ||
| 'com.apple.developer.siri', | ||
| 'com.apple.developer.nfc.readersession.formats', | ||
| ]; |
Contributor
There was a problem hiding this comment.
Do we need to maintain this list of entitlements? Isn't there a way to avoid that? If not, where can we get the list from, so we can be sure it's in sync
Author
There was a problem hiding this comment.
I'm following the list from fastlane
fastlane/fastlane#5130
i believe the list is from https://developer.apple.com/documentation/bundleresources/entitlements
Contributor
There was a problem hiding this comment.
awesome, let's add it as a comment please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #611