feat: allow adhoc for android

[LukasMod]

No description provided.

[vercel]

@LukasMod is attempting to deploy a commit to the Callstack Team on Vercel.

A member of the Team first needs to authorize it.

[thymikee]

Looks good! would love to see a video of a working demo :)

[LukasMod]

I tested with fork LukasMod#1 (same as this one + dist and some changes in package.json to make it executable from project after referencing it in package.json).

Test command: AWS_ACCESS_KEY_ID=... AWS_SECRET_ACCESS_KEY=... npx rock remote-cache upload --name rock-android-Adhoc-9e4710ed8a88da2b491feb31700abf16687eaa66 --binary-path Expensify-adhoc.apk --ad-hoc with .apk placed in root folder.

terminal logs:

◇  Uploaded APK, index.html to S3
│
◇  Artifact information:
│  - name: rock-android-Adhoc-9e4710ed8a88da2b491feb31700abf16687eaa66
│  - url: https://exp-demo-bucket-lm-1.s3.eu-central-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9e4710ed8a88da2b491feb31700abf16687eaa66/index.html

android.adhoc.mp4

Additionally I updated link to rock docs in index template (old one: https://rockjs.dev/docs/cli#ad-hoc-distribution).
If this will be fine, we should mention this in docs properly too.
And its just rock side, android gh action needs to be updated also to reflect these changes and allow for ad-hoc flag.

I used private bucket for tests only (bucket with public access), its already removed to avoid extra costs.

[LukasMod]

Here is example with expensify app: Expensify/App#76061 (comment)
Working solution requires some additional changes:

1. iOS gh actions:

• space in filename: fix: allow space in binary path artifact name ios#23

2. Android gh actions:

• adhoc upload step: feat: adhoc upload step android#16
• same signing as for first build if options are available: fix: pass keystore inputs in re-sign step android#18
• space in filename: fix: allow space in binary path artifact name android#17

3. Rock

• android replace bundle fix: fix: use zip instead of AdmZip replace js bundle #647 - testing last commit in progress

[thymikee]

node-apk adds a lot of install size: https://packagephobia.com/result?p=node-apk. Can we instead use zip command to get the manifest? similar to how we use it in re-sign

[thymikee]

we could use fast-xml-parser (one we use in apple platform) to parse the manifest

[LukasMod]

I will test aapt (locally works). zip + fast-xml-parser was not working because AndroidManifest is binary in this case.

[thymikee]

Looks good! Thanks for contributing that. I left a comment to consider, but no biggie

[thymikee]

we have spawn for running commands, let's use that

[thymikee]

🚀