Skip to content

Maintain number precision by wrapping numbers in strings #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexlopashev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Maintain number precision by wrapping numbers in strings #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 39 additions & 4 deletions extension/js/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@
TYPE_NULL = 6
;

var NUM_HACK_START = "<json_formatter_number_hack>";
var NUM_HACK_END = "</json_formatter_number_hack>";
var NUM_REGEX = new RegExp("^\\d+(\\.\\d*)?$", "g");
var NUM_HACK_REGEX = new RegExp("^" + NUM_HACK_START + "\\d+(\\.\\d*)?" + NUM_HACK_END + "$", "g");

// Utility functions
function removeComments (str) {
str = ('__' + str + '__').split('');
Expand Down Expand Up @@ -206,10 +211,10 @@
;

// Establish value type
if (typeof value === 'string')
type = TYPE_STRING ;
else if (typeof value === 'number')
if (typeof value === 'string' && value.match(NUM_HACK_REGEX))
type = TYPE_NUMBER ;
else if (typeof value === 'string')
type = TYPE_STRING ;
else if (value === false || value === true )
type = TYPE_BOOL ;
else if (value === null)
Expand Down Expand Up @@ -282,7 +287,7 @@
case TYPE_NUMBER:
// Simply add a number element (span.n)
valueElement = templates.t_number.cloneNode(false) ;
valueElement.innerText = value ;
valueElement.innerText = value.substring(NUM_HACK_START.length, value.length - NUM_HACK_END.length) ;
kvov.appendChild(valueElement) ;
break ;

Expand Down Expand Up @@ -415,6 +420,35 @@
// Strip any leading garbage, such as a 'while(1);'
var strippedText = text.substring( firstJSONCharIndex(text) ) ;

// pass all numbers to json parser as strings in order to maintain precision,
// unwrap them later without quotes
var buffer = "";
var numberBuffer = "";
var isInString = false;
var isInNumber = false;
var previous = "";
for (var i = 0, len = strippedText.length; i < len; i++) {
if (strippedText[i] == '"' && previous != '\\')
isInString = !isInString;
if (!isInString && !isInNumber && (('0' <= strippedText[i] && strippedText[i] <= '9') || strippedText[i] == '.'))
isInNumber = true;
if (!isInString && isInNumber && (('0' > strippedText[i] || strippedText[i] > '9') && strippedText[i] != '.')) {
isInNumber = false;
if (numberBuffer.match(NUM_REGEX))
buffer += '"' + NUM_HACK_START + numberBuffer + NUM_HACK_END + '"';
else
buffer += numberBuffer;
numberBuffer = "";
}
if (isInNumber)
numberBuffer += strippedText[i];
else {
buffer += strippedText[i];
previous = strippedText[i];
}
}
strippedText = buffer;

try {
obj = JSON.parse(strippedText) ;
validJsonText = strippedText ;
Expand Down Expand Up @@ -498,3 +532,4 @@
});
});
}()) ;