-
Notifications
You must be signed in to change notification settings - Fork 1
feature/lfs-oid-key #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feature/lfs-oid-key #172
Conversation
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR changes the S3 object key format from {did}/{hash} to just {hash} to align with Git LFS expectations and enable content-addressed storage using SHA-256 OIDs directly.
Changes:
- Updated S3 object key construction to use only the checksum (hash) instead of the
did/checksumpattern - Modified test scripts and Go code to reflect the new key format
- Updated all test assertions to match the new S3 URL structure
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/scripts/utils/list-s3-by-sha256.sh |
Changed object key construction from ${PREFIX}${did}/${hash} to ${PREFIX}${hash} |
tests/scripts/utils/delete-s3-by-sha256.sh |
Changed object key construction from ${PREFIX}${did}/${hash} to ${PREFIX}${hash} and removed trailing blank lines |
client/indexd/indexd_client.go |
Updated BuildDrsObj to construct S3 URLs using only the checksum instead of did/checksum |
client/indexd/indexd_client_test.go |
Updated test assertions to expect S3 URLs with the new key format (bucket/sha-256 instead of bucket/did-1/sha-256) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Motivation
Store objects using checksum-only keys to match Git LFS expectations and enable deterministic, content-addressed storage.
See #171
Description
Use SHA-256 OIDs directly as S3 object keys for DRS access URLs and related S3 utility scripts/tests.