Formal way to take in token for slideUtil (Issue #42) #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a standardized, secure way to handle upload tokens in slideUtil (fixes Issue #42) and updates the SlideServer upload pipeline to properly validate chunk ordering and prevent silent corruption of uploaded slide files (addresses Issue #92).
Fixes / Issues Addressed
Fixes #42 — Formal token handling for slideUtil
Fixes #92 — Chunked upload corruption
What this PR Changes
/upload/continue/<token>The server now validates:
offset == current_temp_file_size409 Offset mismatchtoken_locks = defaultdict(threading.Lock)/upload/finishIf the client provides:
✔ Server correctly rejected out-of-order chunk
✔ Server correctly rejects parallel uploads
✔ Full upload completed with correct SHA