fix: include missing key columns for UPSERT from SELECT queries
#1454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to leave out
keycolumns which have adefaultorcds.on.insertvalue when callingUPSERT. This case was not properly considered when usingUPSERTfromSELECTqueries. This PR ensures to include allkeycolumns into the sourceSELECTquery.behavior
In the case of
HANAthe result of the sourceSELECTis not allowed to have duplicatekeyvalues. As forpostgresandsqlitethey leverage the emergent behavior of anUPSERTthat the rows are allowed to overwrite each other. This is actually an undefined behavior forpostgresandsqlite.As example book
1is being updated inside a singleUPSERTstatement twice. There is no guarantee thattitle 2will be the final result. It is just as valid fortitle 1to be the final result. To prevent these edge casesHANAwill throw an error thatIDis violating an unique constraint even before applying theUPSERTbehavior which invalidates the unique constraint restriction.