Add sorting capabilities and QRCode generation #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- generating QRCodes on the fly - include emails in the QRCodes - sorted badges effectively, with 4 A6 badges per A4 page (eg: the first badge is on top of the second, on top the third and so on, not on the same page.)
- generating QRCodes on the fly - include emails in the QRCodes - sorted badges effectively, with 4 A6 badges per A4 page (eg: the first badge is on top of the second, on top the third and so on, not on the same page.)
Collaborator
|
Hello and thank you for contributing to pybadges. This PR brings in some interesting features to the project! However, it also steers the project in a specific use case while we’d like to keep the project as generic and flexible as possible. That said, here are a few things we’d need to change before we can merge it:
As a general recommendation, I’d also suggest building on top of existing features rather than replacing them entirely, to help keep the codebase consistent and maintainable. As such, I would recommand to make these new features more modular. Thank you again for your contribution! With deeper refactoring, these features could integrate really well in the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added capability to sort based on the number of badges per page, so the first badge is on top of the second (on top of the 3rd and so on) instead of having them all on the same page.
Added capability to generate QRCodes on the fly, instead of giving a list of images to insert