implement #147: memory mapped file backed allocator #148
Open
stepeos wants to merge 1 commit intocapnproto:masterfrom
Open
implement #147: memory mapped file backed allocator #148stepeos wants to merge 1 commit intocapnproto:masterfrom
stepeos wants to merge 1 commit intocapnproto:masterfrom
Conversation
Contributor
Author
|
If the java version bump is an issue, maybe we could instead modify the new constructor for the MessageBuilder and subsequently of the new allocator to take a directory in which to store the files and call the deletion of said folder once the message has been streamed to file for each allocated object (e.g. via callback). This way, the filesystem is not carrying so much redundant data. Then we could totally avoid the cleanup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some isseus I see is that i had to use java's cleaner to ensure that files are deleted when the allocator is GCed, which requires Java 9.
the tests run with the new allocator.