C7A2 whole-project PR for review #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for c7a2-flashcard-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lucjastozek
reviewed
Sep 6, 2023
| <Input | ||
| width={"min-content"} | ||
| variant={"filled"} | ||
| onChange={(e) => setQuestionInput(e.target.value.slice(0, 255))} |
There was a problem hiding this comment.
We think you should inform the user in some way that the limit is 255 (toast maybe?)
lucjastozek
reviewed
Sep 6, 2023
| <Input | ||
| width={"min-content"} | ||
| variant={"filled"} | ||
| onChange={(e) => setQuestionInput(e.target.value.slice(0, 255))} |
There was a problem hiding this comment.
Consider putting 255 in a named variable for better readability and make it dynamic
lucjastozek
reviewed
Sep 6, 2023
| /> | ||
| </Td> | ||
| <Td> | ||
| <Button onClick={onUpdate}> UPDATE </Button> |
There was a problem hiding this comment.
consider using text transform, screen readers really don't like caps locked stuff, they pronounce it letter by letter
lucjastozek
reviewed
Sep 6, 2023
| <HStack width={"max-content"} spacing={3}> | ||
| <Input | ||
| onChange={(e) => | ||
| setDeckNameInput(e.target.value.slice(0, 40)) |
lucjastozek
reviewed
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.