Clean up test to make it easier to fix recent Rails versions #193
+470
−1,141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for all the work @kiskoza. Do we want to do a version bump? I assume no functionality has changed. Just the test environment. |
Member
Author
|
We don't need a version bump yet, but I'm planning to look into #187 which might require one. Let's see it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official support for Rails 6.0 ended more than 2 years ago, for Ruby 2.5 it ended more than 4 years ago. The code base had a lot of special cases that I did not want to fix before adding support for recent Ruby and Rails versions.
I also changed the minimum caxlsx version to 4.0 to keep the scope in a maintainable range (we released it two years ago!)
ToDo: