Store id instead of encoded raw_id on external_id column
#32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to stop using
webauthn-json.With
webauthn-jsonthecreate()method expectscreateOptionsof typeJSON. However, for using the browser's native API, thecreate()call must receive the options in typeCredentialCreationOptions.To pass from
JSONtoCredentialCreationOptionsthe methodparseRequestOptionsFromJSONis used.parseRequestOptionsFromJSONin turn, expects to receive this format: https://www.w3.org/TR/webauthn-3/#dictdef-publickeycredentialcreationoptionsjsonTherefore, the credential ids inside
excludeCredentialsneed to be of typeBase64URLString, which is not the case now.As of now, the
raw_idis beingstrict encodedwhich still doesn't comply with being of typeBase64URLString.With this PR, instead of strictly encoding the
raw_id, theidattribute starts being stored.The id is a base64url encoded version of PublicKeyCredential.rawId.
Related discussion:
webauthn-json#31 (comment)