Skip to content

Conversation

@kashif74
Copy link

Many VO's has been added for voms client setup.

@traylenator
Copy link
Contributor

Thanks , indeed this does need updating for sure.

One question , one of the logs above says 'Change the voms-client rpm name to voms-client3'

First I can't find any evidence of this and second I don't want to happen, the default should
be voms-client but I'm happy for it to be an option to change the package name.

Would be nice if you could improve the comit messages from 'add more vos ' to 'add vos a , b , c.'
Are you able to do that?

@kashif74
Copy link
Author

kashif74 commented Apr 2, 2014

Hi Steve
Commits has been added by three different people including me and I was waiting for cajbrew response about 'Change the voms-client rpm name to voms-client3' . I can see that it is misleading commit message.
Probably I can try to change my commit messages although I don't know how to do it. I also made a mistake that I committed with user name root. Please suggest that how to proceed.
Kashif

@traylenator
Copy link
Contributor

It's tricky because you have done a pull request from master where as you would normally do from
a feature branch.

But you shoud be able to rebase from the commit before branch, inspect

git log --oneline

and then

git rebase -i 123456

This will allow to 'fixup' , 'edit' this commits.

I may just do myself but the commits will not be yours afterwards.

@kashif74
Copy link
Author

kashif74 commented Apr 2, 2014

Its little more tricky because first it was pushed to hep-puppet from oxford-physics and then a pull request was made to cern-ops. If I am doing rebase then it will overwrite merge info as well. I dont know how it will affect commit history. I am fine if you just edit commit from your account.
In future we should keep it simple by sending pull request directly from our repositories and not merging many commit from different people in same pull request.
Thanks
Kashif

kreczko and others added 30 commits May 11, 2016 15:58
compatible to puppet 4
compatible to puppet 4
making compatible to puppet 4
Create solidexperiment_org.pp
lcg-CA package is deprecated, replaced it with ca-policy-egi-core
voms.hellasgrid.gr is unreachable and no longer mentioned in documentation
https://operations-portal.egi.eu/vo/view/voname/dteam
Remove voms.hellasgrid.gr from dteam voms
Changes to voms2.fnal.gov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.