-
Notifications
You must be signed in to change notification settings - Fork 44
Rearrange CF home page into two columns using HTML #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
What is the difference between this suggestion and Andrews suggestion for two columns? Happy to go with either as I think it would look better. I think the difference between these two is just efficiencies in code. Would be good to see a mock up of what it would look like. |
|
There are also some small differences in content. I'm glad you think the two-column arrangement is better. I will redo my content with Andrew's markup/down. |
| <div class="col-md-8" markdown="1"> | ||
|
|
||
| ## Quick links | ||
| <img src="Data/media/images/CF2024_group2_cropped.jpg" style="max-width:100%; height:auto;" alt="Members of the CF community at the 2024 conventions workshop"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe try having both the image and caption in a <figure> element.
Would probably look something like
<figure>
<img src="Data/media/images/CF2024_group2_cropped.jpg" style="max-width:100%; height:auto;" alt="Members of the CF community at the 2024 conventions workshop">
<figcaption>Members of the CF community at the 2024 conventions workshop</figcaption>
</figure>This give the clear semantic relationships between these two element (important for accessibility) and might even by styled for you automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree that would be logically better. I didn't know about <figcaption>. I didn't try this before (although I know you suggested <figure>) because I thought it looked better with the caption beside the figure; I suspected that it might go underneath otherwise. Do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would go underneath. Having the caption beside a figure (like on the current homepage) kinda looks like a layout mistake to me and it wouldn't occur to me that it is intentional. I suppose I have some expectation that its like a figure in a paper/publication.
See #617 for information