Skip to content

Conversation

@rawlingsj
Copy link
Member

This also moves the main functionality of the existing setcomments for a PR, into a helper which is reused by both the set comments for PR and Issue.

Issues don't always have the repository set on the main object, so also have a helper function to get the owner + repo name from the boject if set, else fall back to getting it from the repository URL.

Added test cases for this too.

This also moves the main functionality of the existing setcomments for a PR, into a helper which is reused by both the set comments for PR and Issue.

Issues don't always have the repository set on the main object, so also have a helper function to get the owner + repo name from the boject if set, else fall back to getting it from the repository URL.

Added test cases for this too.

Signed-off-by: rawlingsj <[email protected]>
@rawlingsj rawlingsj force-pushed the issue_set_comemnts branch from 9711438 to 5ae6236 Compare March 24, 2025 11:36
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants