Skip to content

First bit of Tektronix support, also SGR 53/55 (overline) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbanffy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

First bit of Tektronix support, also SGR 53/55 (overline) #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
602dc52
Add overline (SGR 53/55) support
rbanffy Nov 20, 2024
58e10ab
Add Tek mode activation
rbanffy Nov 20, 2024
154ceb6
Make no-overline string consistent
rbanffy Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ func modeDesc(mode int) string {
return "cursor keys"
case 25:
return "cursor visibility"
case 38:
return "tektronix mode"
case 1000:
return "show mouse"
case 1001:
Expand Down
4 changes: 4 additions & 0 deletions sgr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ func handleSgr(parser *ansi.Parser) (string, error) { //nolint:unparam
str += fmt.Sprintf("Background color: %d", readColor(&i, parser.Params))
case 49:
str += "Default background color"
case 53:
str += "Overline"
case 55:
str += "No overline"
Comment on lines +92 to +95
Copy link
Member

@aymanbagabas aymanbagabas Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not widely supported :/

Copy link
Author

@rbanffy rbanffy Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a sad thing. On the bright side, iTerm and VTE (and Konsole, and a couple others) do. Very handy for status lines.

Copy link
Member

@meowgorithm meowgorithm Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if they're not widely supported I can see them being useful, both from a completeness standpoint and for the sake of simply understanding what they are.

Copy link
Member

@aymanbagabas aymanbagabas Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbanffy It would be really helpful to implement these SGR arguments in x/ansi

case 58, 59:
str += fmt.Sprintf("Underline color: %d", readColor(&i, parser.Params))
case 90, 91, 92, 93, 94, 95, 96, 97:
Expand Down