feat: introduce optional mnemonics #57
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add option to display established mnemonics for well-known escape
sequences.
* introduce ECMA-48, DEC, and Xterm mnemonics
* add `--mnemonics`,`-m` flags
* add tests for output changed by flags (raw and mnemonics)
* pass sequence data with `seqInfo` to handle multiple types of info
per one sequence
Signed-off-by: Michał Kotowski <[email protected]>
Closed
Member
|
Thanks for this, @mkotowski. Per #59, I'm converting this to a draft — if we decide to go ahead with it we'll convert it back. |
| var csiHandlers = map[int]handlerFn{ | ||
| 'm': handleSgr, | ||
| 'c': printf("Request primary device attributes"), | ||
| 'c': printWithMnemonic("DA1", "Request primary device attributes"), |
Member
There was a problem hiding this comment.
This is unrelated but the description for DA1 should just be:
Suggested change
| 'c': printWithMnemonic("DA1", "Request primary device attributes"), | |
| 'c': printWithMnemonic("DA1", "Primary device attributes"), |
When there is no parameters \x1b[c, it means a request for the terminal to send its primary device attributes which then responds with something like \x1b[64;1;2;3;4c, the same sequence command but with paramters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(probably a little too over-engineered)
Add option to display established mnemonics for well-known escape sequences to make it easier to search for more information.
--mnemonics,-mflagsseqInfoto handle multiple types of info per one sequenceFurther details:
The optional flag adds
<MNEMONIC>between the dissected contents of the sequence and the explanation. Not displayed in situations likeTextor sequences without mnemonic and when sequence's type is the same as the mnemonic (SOS, PM, …).I believe the current PR introduces mnemonics to all currently handled sequences that have one.
Example:
