Skip to content

Conversation

@oldcai
Copy link

@oldcai oldcai commented Jan 17, 2018

**Support get value by properties or attributes.
Not only data from fields can be rendered to chart.
With it, JSONFields could be loaded by adding a getattr function to model and handle the attribute fetching by reading from JSONField.
**


Before submitting a PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description.
  • Wrote good commit messages.
  • Used the same coding conventions as the rest of the project.
  • Feature branch is up-to-date with master (if not - rebase it)
  • Squashed related commits together.
  • Reviewed the diff manually for unexpected or unrelated changes.
  • Updated README.rst with change log.
  • Tested changes manually.
  • Added automated tests.
  • make coverage tests are passing.

@atodorov
Copy link
Contributor

Can you add an example chart in the demo application for this use case ?

@atodorov
Copy link
Contributor

And please fix all failing tests when making changes. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants