feat: change default sum value from 100 to 1 #3084
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nmrium with
|
| Latest commit: |
496f885
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f35d1c5e.nmrium.pages.dev |
| Branch Preview URL: | https://change-default-sum-value.nmrium.pages.dev |
lpatiny
requested changes
Jun 8, 2024
Member
lpatiny
left a comment
lpatiny
left a comment
There was a problem hiding this comment.
The sum should stay 100 by default. This is what we use for structural analysis exercises.
The change that should be done is the possibility to have the link disabled based on workspace preferences.
And in this case, the relativeH of the first drawn integral is 1.
So what appears in the following video as 282000 should be 1.
The tip of the button could also be renamed (maybe move to the new tip component)
Should become:
'Fixed sum of integrations'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.