-
Notifications
You must be signed in to change notification settings - Fork 2
Refactor/auth architecture pt2 #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
28f9fb4
move auth client adapter to module folder
Dan-Y-Ko 3ee9a3f
refactor rest api port
Dan-Y-Ko 51f5984
implement logout method in auth api port
Dan-Y-Ko 337b94b
add url to auth url constatns
Dan-Y-Ko 81a3f7f
implement logout method in auth api adapter
Dan-Y-Ko 5ea8f84
implement logout method in auth client port
Dan-Y-Ko a6ef63e
add logout usecase
Dan-Y-Ko ecedee5
implement log out in auth client adapter
Dan-Y-Ko 822e132
add logout to di config
Dan-Y-Ko 2649b0d
connect ui to logout
Dan-Y-Ko 80c8ba3
fix lint errors
Dan-Y-Ko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| export const AuthUrls = { | ||
| login: "/api/v1/auth/login", | ||
| logout: "/api/v1/auth/logout", | ||
| } as const; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { inject, injectable } from "tsyringe"; | ||
| import { TYPES } from "@/di/types"; | ||
| import { type AuthApiPort } from "@/modules/auth/ports/secondary/authApiPort"; | ||
| import { type LogoutResponseDto } from "@/modules/auth/application/dtos/response.dto"; | ||
|
|
||
| @injectable() | ||
| export class LogoutUsecase { | ||
| constructor( | ||
| @inject(TYPES.AuthApiPort) | ||
| private readonly authApi: AuthApiPort, | ||
| ) {} | ||
|
|
||
| async execute(): Promise<LogoutResponseDto> { | ||
| return await this.authApi.logout(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| import { type LoginRequestDto } from "@/modules/auth/application/dtos/request.dto"; | ||
| import { type LoginResponseDto } from "@/modules/auth/application/dtos/response.dto"; | ||
| import type { | ||
| LogoutResponseDto, | ||
| LoginResponseDto, | ||
| } from "@/modules/auth/application/dtos/response.dto"; | ||
|
|
||
| export interface AuthClientPort { | ||
| login: (props: LoginRequestDto) => Promise<LoginResponseDto>; | ||
| logout: () => Promise<LogoutResponseDto>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,10 @@ | ||
| import { type LoginRequestDto } from "@/modules/auth/application/dtos/request.dto"; | ||
| import { type LoginResponseDto } from "@/modules/auth/application/dtos/response.dto"; | ||
| import type { | ||
| LogoutResponseDto, | ||
| LoginResponseDto, | ||
| } from "@/modules/auth/application/dtos/response.dto"; | ||
|
|
||
| export interface AuthApiPort { | ||
| login: ({ email, password }: LoginRequestDto) => Promise<LoginResponseDto>; | ||
| logout: () => Promise<LogoutResponseDto>; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.