Skip to content

Conversation

@chipp
Copy link
Owner

@chipp chipp commented Dec 28, 2025

Summary

  • remove deprecated xiaomi crate from the workspace and delete its sources
  • remove xiaomi references from Docker build/test files and docs
  • fix isabel test Dockerfile to run the isabel test set

@gemini-code-assist
Copy link

Summary of Changes

Hello @chipp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on systematically removing the xiaomi Rust crate, which was previously marked as deprecated. The changes encompass the deletion of all source code files belonging to the crate, comprehensive updates to dependency management files (Cargo.toml, Cargo.lock), and the removal of all references within project documentation and Docker build configurations. This cleanup effort streamlines the codebase, removes unused components, and improves the overall maintainability of the project.

Highlights

  • Crate Removal: The deprecated xiaomi Rust crate has been completely removed from the project, including all its source files and associated modules.
  • Dependency Cleanup: Project configuration files, specifically Cargo.toml and Cargo.lock, have been updated to remove references to the xiaomi crate and its direct and indirect dependencies, such as mockall, async-trait, and serde_repr.
  • Documentation and Build Process Updates: Documentation files (AGENTS.md, GEMINI.md) and various Dockerfiles (bin/*/Dockerfile, bin/*/test.Dockerfile) have been updated to remove all mentions and build steps related to the xiaomi crate, ensuring a clean and consistent project setup.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Owner Author

chipp commented Dec 28, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the deprecated xiaomi crate from the project. The changes are comprehensive, covering not only the source code but also the Cargo.toml workspace definition, Cargo.lock, documentation files, and all relevant Dockerfiles. I've found one issue in bin/isabel/test.Dockerfile where a cargo test command seems to be incorrect due to a copy-paste error. While this is a pre-existing issue, this PR touches the line, so it's a good opportunity to fix it. My review includes a suggestion for this correction. Overall, this is a good cleanup PR.

@chipp chipp marked this pull request as ready for review December 28, 2025 21:41
@chipp chipp merged commit 2aab05f into main Dec 28, 2025
6 checks passed
@chipp chipp deleted the remove-xiaomi-crate branch December 28, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants