Add ventilation device type

[chipp]

Summary

• add ventilation device type with serde mapping in alice
• use ventilation type for recuperator device in alisa

[gemini-code-assist]

Summary of Changes

Hello @chipp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the device categorization system by introducing a dedicated Ventilation device type. It reclassifies an existing 'Recuperator' device to use this new, more appropriate type and includes all necessary serialization logic and unit tests to seamlessly integrate the new device type into the alice library.

Highlights

• New Device Type: Introduced a new DeviceType::Ventilation enum variant to accurately represent ventilation devices within the system.
• Device Recategorization: Updated the 'Recuperator' device in bin/alisa/src/web_service/user/devices.rs to correctly use the new DeviceType::Ventilation instead of DeviceType::ThermostatAc.
• Serialization Support and Testing: Added serde attributes for proper serialization and deserialization of the Ventilation device type, along with corresponding unit tests to ensure its correct functionality.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[chipp]

• Add ventilation device type #145 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[gemini-code-assist]

Code Review

This pull request correctly introduces a new Ventilation device type for Yandex Alice integration. The changes include adding the new type to the DeviceType enum, updating the recuperator_device to use it, and adding corresponding serialization and deserialization tests. The implementation is correct. I've added one suggestion to refactor the tests for better maintainability by using a data-driven approach, which will make it easier to add more device types in the future.