Optimize dependencies #148
Conversation
Summary of ChangesHello @chipp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a comprehensive optimization of the project's dependency graph and Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively optimizes dependencies by removing unused crates and features. This is a positive change for build times and binary sizes. However, there is a critical regression in the elisheba service where graceful shutdown handling has been removed. I've also highlighted a major dependency upgrade for the zip crate that warrants careful testing for breaking changes. Please review the specific comments for details.
|
|
||
| futures-util = "0.3" | ||
| tokio = { version = "1", features = ["macros", "rt-multi-thread", "net", "signal", "sync"] } | ||
| tokio = { version = "1", features = ["macros", "rt-multi-thread", "time"] } |
There was a problem hiding this comment.
Removing the signal feature from tokio is problematic as it breaks the graceful shutdown functionality in src/main.rs. Please re-add the signal feature. It's also advisable to keep the net and sync features for a networked, multi-threaded application like this to avoid potential issues.
| tokio = { version = "1", features = ["macros", "rt-multi-thread", "time"] } | |
| tokio = { version = "1", features = ["macros", "rt-multi-thread", "time", "net", "signal", "sync"] } |
| sig.recv().await | ||
| }) => { info!("got SIGTERM, exiting...") }, | ||
| }; | ||
| try_join(set_handle, state_handle).await?; |
There was a problem hiding this comment.
The graceful shutdown logic has been removed. As try_join will block indefinitely, the process can no longer be stopped gracefully via SIGTERM. This is a critical regression. After restoring the signal feature in Cargo.toml, please re-implement the graceful shutdown mechanism here, for example by replacing this line with a tokio::select! block that waits for either the tasks to complete or for a shutdown signal.
| chrono-humanize = "0.2" | ||
|
|
||
| zip = { version = "2.6", default-features = false, features = ["deflate"] } | ||
| zip = { version = "3.0", default-features = false, features = ["deflate"] } |
There was a problem hiding this comment.
The zip crate has been upgraded from version 2.6 to 3.0. This is a major version bump, which often indicates breaking changes. According to the zip crate's changelog, version 3.0 is a rewrite with a focus on streaming support. Please ensure that this upgrade has been thoroughly tested to confirm there are no regressions or unexpected behavior.
No description provided.