Skip to content

Conversation

@oriongonza
Copy link
Collaborator

@oriongonza oriongonza commented Oct 18, 2023

oriongonza

This comment was marked as outdated.

@oriongonza oriongonza force-pushed the ardi/multiple-replaces branch from cb981f2 to a075207 Compare October 19, 2023 09:43
@oriongonza oriongonza force-pushed the ardi/multiple-replaces branch from bd72739 to 4754218 Compare October 20, 2023 01:08
@oriongonza
Copy link
Collaborator Author

oriongonza commented Oct 20, 2023

Done. Caveats:
2 extra vector allocations at the start (should be completely negligible)

  1. changed public API of Replacer::new()
  2. There's probably a more efficient way of achieving what replace does
  3. No colors when there are several patterns.
  4. The regex flags are applied to all patterns

@oriongonza oriongonza marked this pull request as ready for review October 20, 2023 01:37
@CosmicHorrorDev
Copy link
Collaborator

I'll be looking at these after I get this pending release out. Just wanted to give a heads up that I'm not ignoring all of these

@oriongonza
Copy link
Collaborator Author

What's left for the release? The release issue tracker #203 is as complete as it gets.

Can I help with anything?

@oriongonza
Copy link
Collaborator Author

This will be a hacky solution up until the new modular architecture is created and merged. I don't know if it's worth it to release it for 1.1 since the API for it will likely change

@oriongonza
Copy link
Collaborator Author

This doesn't make much sense after #282

@oriongonza oriongonza closed this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants