Skip to content

Conversation

@ulivc
Copy link
Collaborator

@ulivc ulivc commented Nov 7, 2023

Implementation of Tests solving #24.

You can start the tests by running pytest.
This takes a lot of time because of the test test_optimizer.

command to test data_processing:
pytest -v src/tests/pipelines/data_processing/test_pipeline.py::TestDataPreparation

command to test training:
pytest -v src/tests/pipelines/data_science/test_pipeline.py::TestTraining

command to test all optimizers:
pytest -v src/tests/pipelines/data_science/test_pipeline.py::test_optimizer

@ulivc ulivc requested a review from stroblme November 7, 2023 13:22
ulivc and others added 3 commits November 7, 2023 14:23
Copy link
Member

@stroblme stroblme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work!
Added some review comments, mostly regarding config files.
Still need to 'test the test', but looks good so far! :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das können wir vermutlich löschen oder?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Das sieht für mich eher nach einer Test-Konfiguration aus. Das sollte eher lokal bleiben und nicht Teil des Commits werden.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auch das hier, gerne einfach löschen, da es nur eine lokale Konfiguration ist.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S.o.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S.o.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bin mir nicht ganz sicher, aber brauchen wir den Teil nicht?

Base automatically changed from optuna to main May 9, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants